CFM-143_DRY_Refactor_topLinks_and_indexActions_make_use_of_an_element_or_MenuHelper #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ioannis
force-pushed
the
CFM-143_DRY_Refactor_topLinks_and_indexActions_make_use_of_an_element_or_MenuHelper
branch
from
cf4dc34
to
cd6ac46
Compare
|
Hi, Ioannis - I agree with the heart of your question in the code: "Why only with add i have toplinks???" - I believe what was happening here is that "add" was all we started with (much more to come, of course), and then "add" permissions were adequate to determine if the others were to be shown. This is not correct going forward. We should either change the test for "add" to only contain the add link or we should just include add with the other toplinks so that all is consistent. |
Ioannis
force-pushed
the
CFM-143_DRY_Refactor_topLinks_and_indexActions_make_use_of_an_element_or_MenuHelper
branch
from
cd6ac46
to
9b995a6
Compare
|
@arlen I agree with the approach and i removed the comment. If you are okay with the imported functionality for now, let's merge the PR, since we will be making more changes in the near future. |
Ioannis
force-pushed
the
CFM-143_DRY_Refactor_topLinks_and_indexActions_make_use_of_an_element_or_MenuHelper
branch
from
67ac095
to
08fa6ac
Compare
Ioannis
force-pushed
the
CFM-143_DRY_Refactor_topLinks_and_indexActions_make_use_of_an_element_or_MenuHelper
branch
from
0d54a79
to
ca17e3c
Compare
Ioannis
deleted the
CFM-143_DRY_Refactor_topLinks_and_indexActions_make_use_of_an_element_or_MenuHelper
branch
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top links on the index view